[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Patch for BUG ID 994657



On 08/07/2013 12:07 PM, Schmaus, John M. (John) wrote:
> Hi All,
> 
> Here is the change I made to address the SIGSEGV we were seeing in libvirtd when attempting to create a new VM via virt-install:

Thanks for taking time to identify a problem and propose a patch.  Your
patch didn't apply via 'git am' (see HACKING for details on how to
submit a patch that is friendlier to reviewers).  Also, your patch uses
C99 // comments, which we prefer not to have in our code base.

Finally, Stefan Bader beat you to the punch:

commit 9d0557b9655fe4a3f31af2e1cc2f33de8acfaa7d
Author: Stefan Bader <stefan bader canonical com>
Date:   Wed Jul 31 11:59:21 2013 +0200

    xen: Avoid double free of virDomainDef in xenDaemonCreateXML

    The virDomainDef is allocated by the caller and also used after
    calling to xenDaemonCreateXML. So it must not get freed by the
    callee.

    Signed-off-by: Stefan Bader <stefan bader canonical com>

As such, I've gone ahead and closed bug 994657.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]