[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags



At Thu,  8 Aug 2013 16:48:46 +0800,
Alex Jia wrote:
> 
...
> # virsh start <domain> --paused
> 
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=994855
> 
> 
> Signed-off-by: Alex Jia <ajia redhat com>
> ---
>  src/remote/remote_driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index f828eef..71d0034 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -2431,6 +2431,7 @@ remoteDomainCreateWithFlags(virDomainPtr dom, unsigned int flags)
>      make_nonnull_domain(&args.dom, dom);
>      args.flags = flags;
>  
> +    memset(&ret, 0, sizeof(ret));
>      if (call(dom->conn, priv, 0, REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS,
>               (xdrproc_t)xdr_remote_domain_create_with_flags_args, (char *)&args,
>               (xdrproc_t)xdr_remote_domain_create_with_flags_ret, (char *)&ret) == -1) {
> -- 
> 1.7.1

ACK.

I've just been bitten by this as well. Your patch fixes it for me.

Thanks.

/ Claudio
-- 
AV-Test GmbH, Henricistra├če 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>

Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]