[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: the compiler is not always named gcc



On Wed, Aug 07, 2013 at 09:46:06AM -0600, Eric Blake wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=994589 complained that
> even when using a cross-compiler not named 'gcc', the configure
> output confusingly referred to gcc.
> 
> * m4/virt-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): Use a
> more generic statement in configure output.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
> 
> Pushing under the trivial rule.
> 
>  m4/virt-compile-warnings.m4 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
> index 8731b70..6bf797f 100644
> --- a/m4/virt-compile-warnings.m4
> +++ b/m4/virt-compile-warnings.m4
> @@ -62,7 +62,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
> 
>      # gcc 4.2 treats attribute(format) as an implicit attribute(nonnull),
>      # which triggers spurious warnings for our usage
> -    AC_CACHE_CHECK([whether gcc -Wformat allows NULL strings],
> +    AC_CACHE_CHECK([whether the C compiler's -Wformat allows NULL strings],
>        [lv_cv_gcc_wformat_null_works], [
>        save_CFLAGS=$CFLAGS
>        CFLAGS='-Wunknown-pragmas -Werror -Wformat'
> @@ -101,7 +101,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
> 
>      dnl Check whether strchr(s, char variable) causes a bogus compile
>      dnl warning, which is the case with GCC < 4.6 on some glibc
> -    AC_CACHE_CHECK([whether GCC -Wlogical-op gives bogus warnings],
> +    AC_CACHE_CHECK([whether the C compiler's -Wlogical-op gives bogus warnings],
>        [lv_cv_gcc_wlogical_op_broken], [
>        save_CFLAGS="$CFLAGS"
>        CFLAGS="-O2 -Wlogical-op -Werror"

ACK.
 -- Guido

> -- 
> 1.8.3.1
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]