[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: avoid C99 loop declaration



On 08/08/2013 12:41 PM, Guido Günther wrote:
> On Wed, Aug 07, 2013 at 04:53:30PM -0600, Eric Blake wrote:
>> Commit 3d0e3c1 reintroduced a problem previously squelched in
>> commit 7e5aa78.  Add a syntax check this time around.
> 
> Didn't notice we want to avoid this sorry.

That's okay - it's my own fault for not adding a syntax-check last time
it happened.  Eventually, we will reach a day where we quit catering to
RHEL 5's ancient gcc as our minimum version, but at least now we can
detect the problem without having to resort to waiting for someone to
actually test the build on RHEL 5...

Maybe it's worth someone trying to set up an autobuilder on a RHEL 5 VM?
 (My own RHEL 5 setup is too sporadic, on only once a month or so,
mainly for my own regression testing).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]