[libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell
John Ferlan
jferlan at redhat.com
Fri Aug 9 11:02:28 UTC 2013
On 08/09/2013 07:01 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> The virLoginShellAllowedUser method must not free the 'groups'
> parameter it is given, as that is owned by the caller.
>
> The virLoginShellAllowedUser method should be checking
> '!*ptr' (ie empty string) rather than '!ptr' (NULL string)
> since the latter cannot be true.
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> tools/virt-login-shell.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
ACK
John
More information about the libvir-list
mailing list