[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell



On 08/09/2013 07:01 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virLoginShellAllowedUser method must not free the 'groups'
> parameter it is given, as that is owned by the caller.
> 
> The virLoginShellAllowedUser method should be checking
> '!*ptr' (ie empty string) rather than '!ptr' (NULL string)
> since the latter cannot be true.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  tools/virt-login-shell.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

ACK


John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]