[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell



On 08/09/2013 05:01 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virLoginShellAllowedUser method must not free the 'groups'
> parameter it is given, as that is owned by the caller.
> 
> The virLoginShellAllowedUser method should be checking
> '!*ptr' (ie empty string) rather than '!ptr' (NULL string)
> since the latter cannot be true.

This only fixes the blatant errors that I called out, but there are
still more (cosmetic) fixes needed:
https://www.redhat.com/archives/libvir-list/2013-August/msg00398.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]