[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.



On 08/09/2013 04:51 AM, John Ferlan wrote:

> 
> 88   	                    if (!ptr)
> 
> (4) Event dead_error_line: 	Execution cannot reach this statement "continue;".
> Also see events: 	[assignment][notnull][dead_error_condition]
> 
> 89   	                        continue;
> 
> Did you perhaps mean (!*ptr) (eg, the contents not the value?)

Ha - I caught that one earlier in the day by manual code inspection :)
https://www.redhat.com/archives/libvir-list/2013-August/msg00398.html

I also caught other instances of dead code not listed by Coverity,
although with less impact.

> 
> 
> #2: USE_AFTER_FREE: main()

But I missed that one, so Coverity is still proving useful.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]