[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Build QEMU command line for pcihole64



On Mon, Aug 12, 2013 at 03:08:39PM +0200, Ján Tomko wrote:
> QEMU commit 3984890 introduced the "pci-hole64-size" property,
> to i440FX-pcihost and q35-pcihost with a default setting of 2 GB.
> 
> Translate <pcihole64 size='x'/> to:
> -global q35-pcihost.pci-hole64-size=x for q35 machines and
> -global i440FX-pcihost.pci-hole64-size=x for i440FX-based machines.

I'm not particularly attracted by the idea of stuffing this
info into the <features> XML element. That is in danger of just
becoming a generic dumping ground for random data.  It was
originally intended as just a list of boolean toggles, and the
hyper-v support has abused that in a way that's not strictly
backwards compatible - eg any app that treats elements as a
simple set of booleans will be loosing data.

Based on the CLI args there, this PCI hole data is really
associated with the PCI root controller device. Can we model
this against a <controller> element for the PCI root perhaps.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]