[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/5] cgroup macros refactoring



On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
> Complete moving to VIR_CGROUP_SUPPORTED
> ---
>  src/util/vircgroup.c | 497 ++++++++++++++++++++++++++++-----------------------
>  1 file changed, 272 insertions(+), 225 deletions(-)
> 

This one felt a bit big...

>  
> -#if defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R
> +
> +#ifdef VIR_CGROUP_SUPPORTED
> +bool virCgroupAvailable(void)

You're rearranging functions,...

> @@ -346,6 +473,7 @@ cleanup:
>      return ret;
>  }
>  
> +
>  static int virCgroupDetect(virCgroupPtr group,

...fixing whitespace...

> @@ -1242,17 +1376,6 @@ cleanup:
>      VIR_FREE(newpath);
>      return ret;
>  }
> -#else
> -int virCgroupNewPartition(const char *path ATTRIBUTE_UNUSED,
> -                          bool create ATTRIBUTE_UNUSED,
> -                          int controllers ATTRIBUTE_UNUSED,
> -                          virCgroupPtr *group ATTRIBUTE_UNUSED)

...and moving #else clauses, all in one patch.  I'm probably going to
split this up a bit.

But it still looks reasonable; ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]