[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/5] cgroup macros refactoring



On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
> Complete the refactoring by adding missing stubs so it compiles on
> platform without cgroup support.
> ---
>  src/util/vircgroup.c | 311 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 306 insertions(+), 5 deletions(-)

ACK.

> @@ -3032,6 +3068,7 @@ int virCgroupNewEmulator(virCgroupPtr domain ATTRIBUTE_UNUSED,
>      return -1;
>  }
>  
> +
>  int virCgroupNewDetect(pid_t pid ATTRIBUTE_UNUSED,

Should be squashed earlier.

> +
> +bool virCgroupNewIgnoreError(void)
> +{
> +    virReportSystemError(ENXIO, "%s",
> +                         _("Control groups not supported on this platform"));
> +    return false;

Not sure if this one should be silent.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]