[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Link to virdbustest against DBus libs



On Mon, Aug 12, 2013 at 01:21:08PM -0600, Eric Blake wrote:
> On 08/12/2013 01:14 PM, Guido Günther wrote:
> > otherwise we fail like:
> > 
> >     CCLD     virdbustest
> >     /usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol 'dbus_message_unref'
> >     /lib/x86_64-linux-gnu/libdbus-1.so.3: error adding symbols: DSO missing from command line
> >     collect2: error: ld returned 1 exit status
> > 
> > Found by:
> > 
> >     http://honk.sigxcpu.org:8001/job/libvirt-build-debian-sid-amd64/7/console
> > ---
> >  tests/Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK.

I found several more places which fail to link with a strict
--no-copy-dt-needed-entries. See my followup patch which superseeds this
one.
Cheers,
 -- Guido


> 
> > 
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index 4aa02dd..d6f60a1 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -673,7 +673,7 @@ if WITH_DBUS
> >  virdbustest_SOURCES = \
> >  	virdbustest.c testutils.h testutils.c
> >  virdbustest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS)
> > -virdbustest_LDADD = $(LDADDS)
> > +virdbustest_LDADD = $(LDADDS) $(DBUS_LIBS)
> >  
> >  virsystemdtest_SOURCES = \
> >  	virsystemdtest.c testutils.h testutils.c
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]