[libvirt] [PATCH] Fix qemuProcessReadLog with non-zero offset
Ján Tomko
jtomko at redhat.com
Thu Aug 15 13:36:32 UTC 2013
On 08/15/2013 03:18 PM, Eric Blake wrote:
> On 08/15/2013 07:10 AM, Ján Tomko wrote:
>> This restores the error message when QMP probing is not used.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=991334
>> ---
>> src/qemu/qemu_process.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> ACK.
>
>> +++ b/src/qemu/qemu_process.c
>> @@ -1435,18 +1435,17 @@ qemuProcessReadLog(int fd, char *buf, int buflen, int off)
>> ssize_t bytes;
>> char *eol;
>>
>> - buf[0] = '\0';
>
> A smaller fix might be to change this to buf[off] = '\0'; but your way
> is just fine as is.
Thanks, pushed now.
Jan
More information about the libvir-list
mailing list