[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Consistently use 'CANCELED' spelling in public API



On Mon, Aug 19, 2013 at 10:53:28AM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 19, 2013 at 11:44:39AM +0200, Christophe Fergeau wrote:
> > Most constant names in libvirt public API are using the 'CANCELED'
> > spelling, except for VIR_DOMAIN_JOB_CANCELLED and
> > VIR_ERR_AUTH_CANCELLED.
> > 
> > This commit changes the spelling used by these 2 symbols to make
> > it consistant with the rest of the API. For backwards compatibility,
> > 2 #define are introduced using the old spelling (with 2 'L').
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau redhat com>
> > ---
> >  include/libvirt/libvirt.h.in | 10 +++++++++-
> >  include/libvirt/virterror.h  | 10 +++++++++-
> >  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> This has been proposed before, but rejected. Although the misspelling
> sucks, it doesn't really cause any serious pain to apps. Any app that
> used the new spelling  would be needlessly tieing itself to new libvirt.
> So IMHO it better to just live with this.

Yup, does not cause pain, but this makes the API look less polished than it
could. One can also argue that the tieing to a new libvirt would be
compile-time only, and easy to workaround.
Anyway, I'm fine with dropping this patch, especially as this has already
been discussed.

Christophe

Attachment: pgpBrFh7r0Rxb.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]