[libvirt] [PATCH] virBitmapParse: Fix behavior in case of error

Eric Blake eblake at redhat.com
Mon Aug 19 15:17:21 UTC 2013


On 08/19/2013 08:23 AM, Peter Krempa wrote:
> Re-arrange the code so that the returned bitmap is always initialized to
> NULL even on early failures and return an error message as some callers
> are already expecting it.
> ---
>  src/util/virbitmap.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

ACK.

Are there any callers that are overwriting the error message when they
shouldn't be?  But that can be a separate patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130819/739fb118/attachment-0001.sig>


More information about the libvir-list mailing list