[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virBitmapParse: Fix behavior in case of error



On 08/19/2013 08:23 AM, Peter Krempa wrote:
> Re-arrange the code so that the returned bitmap is always initialized to
> NULL even on early failures and return an error message as some callers
> are already expecting it.
> ---
>  src/util/virbitmap.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

ACK.

Are there any callers that are overwriting the error message when they
shouldn't be?  But that can be a separate patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]