[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/9] qemu: Don't add default memballoon device on ARM



On Sun, Aug 18, 2013 at 02:57:54PM -0400, Cole Robinson wrote:
> And add test cases for a basic working ARM guest.

Does virtio-balloon not work on ARM ?  I thought that was an architecture
angostic device type.

> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 12b68ea..13a3cac 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -8812,7 +8812,6 @@ virDomainVideoDefaultRAM(virDomainDefPtr def,
>      }
>  }
>  
> -
>  int
>  virDomainVideoDefaultType(virDomainDefPtr def)
>  {
> @@ -12147,19 +12146,6 @@ virDomainDefParseXML(xmlDocPtr xml,
>  
>          def->memballoon = memballoon;
>          VIR_FREE(nodes);
> -    } else {
> -        if (def->virtType == VIR_DOMAIN_VIRT_XEN ||
> -            def->virtType == VIR_DOMAIN_VIRT_QEMU ||
> -            def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
> -            def->virtType == VIR_DOMAIN_VIRT_KVM) {
> -            virDomainMemballoonDefPtr memballoon;
> -            if (VIR_ALLOC(memballoon) < 0)
> -                goto error;
> -            memballoon->model = def->virtType == VIR_DOMAIN_VIRT_XEN ?
> -                VIR_DOMAIN_MEMBALLOON_MODEL_XEN :
> -                VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO;
> -            def->memballoon = memballoon;
> -        }

This chunk I'd expect in the previous path.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]