[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] virt-pki-validate: add --help/--version option




----- Original Message -----
From: "Eric Blake" <eblake redhat com>
To: libvir-list redhat com
Sent: Monday, August 19, 2013 6:43:15 PM
Subject: [libvirt] [PATCH 3/3] virt-pki-validate: add --help/--version option

Another program gains --help/--version :)

* tools/virt-pki-validate.in: Add option parsing.  Update
documentation to match.
* tools/Makefile.am (virt-pki-validate): Substitute version.

Signed-off-by: Eric Blake <eblake redhat com>
---
 tools/Makefile.am          |  5 +++--
 tools/virt-pki-validate.in | 45 ++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 47 insertions(+), 3 deletions(-)

...

diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in
index 5d0453f..87fb230 100755
--- a/tools/virt-pki-validate.in
+++ b/tools/virt-pki-validate.in
@@ -22,6 +22,35 @@
 #
 # Daniel Veillard <veillard redhat com>
 #
+
+case $1 in
+case $1 in

copy-paste error, double case lines.


+  -h | --h | --he | --hel | --help)
+    cat <<EOF
...

+
+if test $# != 0; then
+    echo "$0: unrecognized argument '$1'" >&2
+    exit 1 ;;

remove ;; here.


ACK with these small fixes.

-- 
1.8.3.1

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]