[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] virt-pki-validate: add --help/--version option



On 08/19/2013 08:01 PM, Guan Nan Ren wrote:
> 
> 
> ----- Original Message -----
> From: "Eric Blake" <eblake redhat com>
> To: libvir-list redhat com
> Sent: Monday, August 19, 2013 6:43:15 PM
> Subject: [libvirt] [PATCH 3/3] virt-pki-validate: add --help/--version option
> 
> Another program gains --help/--version :)
> 

> +
> +case $1 in
> +case $1 in
> 
> copy-paste error, double case lines.

Oops - must have hit send before my final save.  Thanks for catching that.

> 
> 
> +  -h | --h | --he | --hel | --help)
> +    cat <<EOF
> ...
> 
> +
> +if test $# != 0; then
> +    echo "$0: unrecognized argument '$1'" >&2
> +    exit 1 ;;
> 
> remove ;; here.
> 
> 
> ACK with these small fixes.

After one more round of testing, I pushed the fixed patches.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]