[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/9] virsh: C99 style for info_domfstrim and opts_lxc_enter_namespace



On 08/20/2013 02:02 PM, Tomas Meszaros wrote:
> Change info_domfstrim and opts_lxc_enter_namespace initialization style
> to C99.
> ---
>  tools/virsh-domain.c | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)

ACK.  I wonder if it is worth adding a 'make syntax-check' test that
enforces this style within virsh files, but don't have a good suggestion
for a foolproof regex that would detect C89 initialization.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]