[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/4] add hostdev passthrough common library



On Mon, Aug 19, 2013 at 04:49:37PM -0400, cyliu suse com wrote:
> +
> +/* functions to get active/inactive lists */
> +virHostdevNameListPtr
> +virHostdevGetActivePciHostdevs(virHostdevManagerPtr mgr);
> +
> +virHostdevNameListPtr
> +virHostdevGetActiveUsbHostdevs(virHostdevManagerPtr mgr);
> +
> +virHostdevNameListPtr
> +virHostdevGetActiveScsiHostdevs(virHostdevManagerPtr mgr);
> +
> +virHostdevNameListPtr
> +virHostdevGetDomainActivePciHostdevs(virHostdevManagerPtr mgr,
> +                                     const char *drv_name,
> +                                     const char *dom_name);
> +virHostdevNameListPtr
> +virHostdevGetDomainActiveUsbHostdevs(virHostdevManagerPtr mgr,
> +                                     const char *drv_name,
> +                                     const char *dom_name);
> +virHostdevNameListPtr
> +virHostdevGetDomainActiveScsiHostdevs(virHostdevManagerPtr mgr,
> +                                      const char *drv_name,
> +                                      const char *dom_name);
> +/* function to free memory after get active/inactive lists */
> +void virHostdevNameListFree(virHostdevNameListPtr list);

Perhaps I'm missing something, but I don't see these methods
used in any of your patches.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]