[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: fix building without xattr support



At Wed, 21 Aug 2013 13:55:27 +0100,
Daniel P. Berrange wrote:
> 
> On Wed, Aug 21, 2013 at 09:28:26AM +0200, Claudio Bley wrote:
> > Only compile securityselinuxhelper.c if xattr support was detected to
> > avoid this error:
> > 
> > securityselinuxhelper.c:34:24: fatal error: attr/xattr.h: No such file
> > or directory compilation terminated.
> > 
> > Since all SELinux tests depend upon the securityselinuxhelper library,
> > these test programs are now only build when xattr support is
> > available.
> > 
> > Signed-off-by: Claudio Bley <cbley av-test de>
> > ---
> > I'm by no means an automake/SELinux expert and thus I am unsure whether this
> > is the right thing to do.
> > 
> > Especially since in commit 95577af442e5 Eric commented that the
> > "Makefile already guaranteed xattr support." which is obviously not the
> > the case, but maybe I'm just missing something...
> > 
> >  tests/Makefile.am |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> ACK, this is right.

Alright, pushed. Thanks!

Claudio
-- 
AV-Test GmbH, Henricistra├če 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>

Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]