[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] VMX: Improve disk parse error for unknown values



On Wed, Aug 21, 2013 at 4:46 PM, Eric Blake <eblake redhat com> wrote:
On 08/17/2013 01:56 PM, Doug Goldstein wrote:
> Previously the error message showed the following:
>
> error: internal error: Invalid or not yet handled value 'auto detect'
> for VMX entry 'ide0:0.fileName'
>
> This left the user unsure if it was a CD-ROM or a disk device that they
> needed to fix. Now the error shows:
>
> error: internal error: Invalid or not yet handled value 'auto detect'
> for VMX entry 'ide0:0.fileName' for device type 'cdrom-raw'
>
> Which should hopefully make it easier to see the issue with the VMX
> configuration.
> ---
>  src/vmx/vmx.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)

ACK.


Thanks. I pushed this but the rest of the series has some more work given the feedback from IRC.
 
--
Doug Goldstein

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]