[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix URI connect precedence



On 08/21/2013 12:00 PM, Daniel P. Berrange wrote:
> On Wed, Aug 21, 2013 at 11:15:39AM +0200, Martin Kletzander wrote:
>> Commit abfff210 changed the order of vshParseArgv() and vshInit() in
>> order to make fix debugging of parameter parsing.  However, vshInit()
>> did a vshReconnect() even though ctl->name wasn't set according to the
>> '-c' parameter yet.  In order to keep both issues fixed, I've split
>> the vshInit() into vshInitDebug() and vshInit().
>>
>> One simple memleak of ctl->name is fixed as a part of this patch,
>> since it is related to the issue it's fixing.
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=999323
>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>> ---
>>  tools/virsh.c | 28 +++++++++++++++++-----------
>>  1 file changed, 17 insertions(+), 11 deletions(-)
> 
> This looks like something we can usefully test for.
> 
> eg create a test suite that does something like this
> 
>  URI1=test:///$(top_srcdir)/examples/test/testnode.xml
>  URI2=test:///$(top_srcdir)/examples/test/testnodeinline.xml
> 
>  export LIBVIRT_DEFAULT_URI=$URI1
>  GOTURI=`virsh -c $URI2 uri`
> 
>  if $GOTURI == $URI2
>   ....pass...
>  else
>    ...fail...
>  fi
> 

Thanks for the tip, I'll also add all possible settings for URIs in the
test to make sure we don't break anything else as well.

[...]
> ACK
> 

Thanks, I pushed this and will send the test for review after I polish
it a bit.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]