[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] virBitmapParse: Fix behavior in case of error and fix up callers



On 08/21/13 18:32, Eric Blake wrote:
> On 08/21/2013 07:12 AM, Peter Krempa wrote:
>> Re-arrange the code so that the returned bitmap is always initialized to
>> NULL even on early failures and return an error message as some callers
>> are already expecting it. Fix up the rest not to shadow the error.
>> ---
>>
>> Version 2:
>>  - squashed cleanup of callers into this patch
>>

...

> Ugg - I don't like easy-to-trigger user-visible error messages that
> state "internal error".  I think VIR_ERR_INVALID_ARG works better.
> 
> ACK with that tweak.
> 

Right, INVALID_ARG is better. Fixed and pushed.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]