[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] HACKING: Introduce basic Signed-off-by politic



With the rising number of signed-off patches appearing on the list,
we should have policy what signed-off means, and advice (enforce?)
contributors to use it.

Signed-off-by: Michal Privoznik <mprivozn redhat com>
---
 HACKING              |  8 ++++++--
 docs/hacking.html.in | 12 ++++++++----
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/HACKING b/HACKING
index f9f8381..e54e584 100644
--- a/HACKING
+++ b/HACKING
@@ -73,8 +73,12 @@ commit introduced the problem, mentioning that is useful. If the patch
 resolves a bugzilla report, mentioning the URL of the bug number is useful;
 but also summarize the issue rather than making all readers follow the link.
 You can use 'git shortlog -30' to get an idea of typical summary lines.
-Libvirt does not currently attach any meaning to Signed-off-by: lines, so it
-is up to you if you want to include or omit them in the commit message.
+Moreover, you should sign off your patches, meaning you are the original
+author(s) of them and you have right to submit them under the open source
+license indicated in the file. To add the "Signed-off-by:" line to the commit
+message automatically, you can tweak the git configuration:
+
+  git config format.signoff true
 
 
 
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 543c77e..f1a5c59 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -78,10 +78,14 @@
           of the bug number is useful; but also summarize the issue
           rather than making all readers follow the link.  You can use
           'git shortlog -30' to get an idea of typical summary lines.
-          Libvirt does not currently attach any meaning to
-          Signed-off-by: lines, so it is up to you if you want to
-          include or omit them in the commit message.
-        </p>
+          Moreover, you should sign off your patches, meaning you are the
+          original author(s) of them and you have right to submit them under
+          the open source license indicated in the file. To add the
+          <code>Signed-off-by:</code> line to the commit message automatically,
+          you can tweak the git configuration: </p>
+<pre>
+  git config format.signoff true
+</pre>
       </li>
 
       <li><p>Split large changes into a series of smaller patches,
-- 
1.8.1.5


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]