[libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags
Eric Blake
eblake at redhat.com
Tue Aug 27 11:57:53 UTC 2013
On 08/27/2013 01:53 AM, Alex Jia wrote:
> The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by qemuDomainBlockCommit(),
> and then will hit error "unsupported flags (0x2) in function
> qemuDomainBlockCommit" if users run 'virsh blockcommit' with '--delete' option.
>
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1001475
>
> Signed-off-by: Alex Jia <ajia at redhat.com>
> ---
> src/qemu/qemu_driver.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index ed29373..8863124 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -14444,7 +14444,8 @@ qemuDomainBlockCommit(virDomainPtr dom, const char *path, const char *base,
> const char *base_canon = NULL;
> bool clean_access = false;
>
> - virCheckFlags(VIR_DOMAIN_BLOCK_COMMIT_SHALLOW, -1);
> + virCheckFlags(VIR_DOMAIN_BLOCK_COMMIT_SHALLOW |
> + VIR_DOMAIN_BLOCK_COMMIT_DELETE, -1);
NACK. You can't add the the flag to the list of supported flags unless
you also add the support for that flag.
This is a case of known future expansion (just as block-resize --shrink)
- the API was planned for full capability, but no one has had time yet
to implement all of the API for all of the hypervisor drivers.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130827/95b59700/attachment-0001.sig>
More information about the libvir-list
mailing list