[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate



On 08/27/2013 08:07 AM, Eric Blake wrote:
> On 08/27/2013 06:03 AM, Laine Stump wrote:
>> On 08/26/2013 09:39 AM, Ján Tomko wrote:
>>> If the network has not been found, virNetworkFree(NULL)
>>> was called, resulting in an extra error:
>>> error: invalid network pointer in virNetworkFree
>>
>> The patch is okay, but all vir*Free() functions should be NOPs when the
>> argument is NULL.
> All _internal_ vir*Free functions should be NOPs.  All public vir*Free
> APIs (including virNetworkFree) are documented to explicitly fail on
> NULL arguments (more precisely, on any argument not created by an
> earlier API call), and we cannot change that behavior as it would be an
> API change that violates back-compat.
>

Ah, sorry. I wasn't paying close attention, just saw a Free() function
and wrote a knee-jerk reply before looking further.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]