[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] cpu_models: implement the remote protocol



"Daniel P. Berrange" <berrange redhat com> writes:

>> +struct remote_connect_get_cpu_model_names_args {
>> +    remote_nonnull_string arch;
>> +    unsigned int flags;
>> +};
>> +
>> +struct remote_connect_get_cpu_model_names_ret {
>> +    remote_nonnull_string models<>;
>
> Use of <> is forbidden - please define a constant for the upper bound
> of this array and check the length on both client and server side.
>
> (Yes, some existing APIs don't do this & they are being fixed).

oops, I had that in the first implementation and then I removed it as I
thought other APIs had no arbitrary limit on purpose.

I will amend this change in the next version.

Thanks,
Giuseppe


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]