[libvirt] [PATCH v3 3/4] Add pcihole64 element to root PCI controllers
Daniel P. Berrange
berrange at redhat.com
Tue Aug 27 13:37:04 UTC 2013
On Thu, Aug 15, 2013 at 01:30:20PM +0200, Ján Tomko wrote:
> <controller type='pci' index='0' model='pci-root'>
> <pcihole64 unit='KiB'>1048576</pcihole64>
> </controller>
>
> It can be used to adjust (or disable) the size of the 64-bit
> PCI hole. The size attribute is in kilobytes (different unit
> can be specified on input), but it gets rounded up to
> the nearest GB by QEMU.
>
> Disabling it will be needed for guests that crash with the
> 64-bit PCI hole (like Windows XP), see:
> https://bugzilla.redhat.com/show_bug.cgi?id=990418
> ---
> docs/formatdomain.html.in | 9 ++++++
> docs/schemas/domaincommon.rng | 32 +++++++++++++++------
> src/conf/domain_conf.c | 26 +++++++++++++++--
> src/conf/domain_conf.h | 8 ++++++
> .../qemuxml2argv-pcihole64-gib.xml | 23 +++++++++++++++
> .../qemuxml2argv-pcihole64-none.xml | 23 +++++++++++++++
> .../qemuxml2argv-pcihole64-q35.xml | 33 ++++++++++++++++++++++
> tests/qemuxml2argvdata/qemuxml2argv-pcihole64.xml | 23 +++++++++++++++
> .../qemuxml2xmlout-pcihole64-gib.xml | 23 +++++++++++++++
> tests/qemuxml2xmltest.c | 5 ++++
> 10 files changed, 195 insertions(+), 10 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcihole64-gib.xml
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcihole64-none.xml
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcihole64-q35.xml
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcihole64.xml
> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pcihole64-gib.xml
ACK though it'd be good to get a second ack on the XML design
before pushing.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list