[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/9] test: Implement readonly snapshot APIs



On 08/30/2013 10:03 AM, Cole Robinson wrote:
> This is just stolen from qemu_driver.c with tweaks to fit the
> test driver.
> ---
>  src/test/test_driver.c | 392 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 392 insertions(+)

Looks fairly straightforward.  ACK post-1.1.2.  (Of course, with this
patch alone, there are no snapshots to be listed, so the new API don't
do anything interesting yet... :)

> +
> +static int
> +testDomainSnapshotListNames(virDomainPtr domain,
> +                            char **names,
> +                            int nameslen,
> +                            unsigned int flags)
> +{
> +    virDomainObjPtr vm = NULL;
> +    int n = -1;
> +
> +    virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
> +                  VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> +

Are we sure that all of the filters are supported?  I guess all of them
will work, even if some of them always land one way and not another (for
example, if you declare that all test snapshots have no metadata, then
the VIR_DOMAIN_SNAPSHOT_LIST_METADATA filter will be rather boring).

> +    .domainSnapshotNum = testDomainSnapshotNum, /* 1.1.2 */
> +    .domainSnapshotListNames = testDomainSnapshotListNames, /* 1.1.2 */
> +    .domainListAllSnapshots = testDomainListAllSnapshots, /* 1.1.2 */
> +    .domainSnapshotGetXMLDesc = testDomainSnapshotGetXMLDesc, /* 1.1.2 */
> +    .domainSnapshotNumChildren = testDomainSnapshotNumChildren, /* 1.1.2 */
> +    .domainSnapshotListChildrenNames = testDomainSnapshotListChildrenNames, /* 1.1.2 */
> +    .domainSnapshotListAllChildren = testDomainSnapshotListAllChildren, /* 1.1.2 */
> +    .domainSnapshotLookupByName = testDomainSnapshotLookupByName, /* 1.1.2 */
> +    .domainHasCurrentSnapshot = testDomainHasCurrentSnapshot, /* 1.1.2 */
> +    .domainSnapshotGetParent = testDomainSnapshotGetParent, /* 1.1.2 */
> +    .domainSnapshotCurrent = testDomainSnapshotCurrent, /* 1.1.2 */
> +    .domainSnapshotIsCurrent = testDomainSnapshotIsCurrent, /* 1.1.2 */
> +    .domainSnapshotHasMetadata = testDomainSnapshotHasMetadata, /* 1.1.2 */

Of course, since this is a new feature being posted after freeze, and
I'm requesting that it go in post-release, that implies touching these
up to say 1.1.3.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]