[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add documentation for access control system



On 08/08/2013 05:27 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> This adds two new pages to the website, acl.html describing
> the general access control framework and permissions models,
> and aclpolkit.html describing the use of polkit as an
> access control driver.
> 

> +++ b/docs/Makefile.am
> @@ -128,7 +128,7 @@ fig = \
>    migration-unmanaged-direct.fig
>  
>  EXTRA_DIST=					\
> -  apibuild.py \
> +  apibuild.py genaclperms.pl \
>    site.xsl newapi.xsl news.xsl page.xsl \
>    hacking1.xsl hacking2.xsl wrapstring.xsl \
>    $(dot_html) $(dot_html_in) $(gif) $(apihtml) $(apipng) \
> @@ -139,6 +139,16 @@ EXTRA_DIST=					\
>    sitemap.html.in \
>    todo.pl hvsupport.pl todo.cfg-example
>  
> +BUILT_SOURCES += aclperms.htmlinc
> +
> +CLEANFILES = aclperms.htmlinc
> +
> +acl.html:: aclperms.htmlinc
> +
> +aclperms.htmlinc: $(top_srcdir)/src/access/viraccessperm.h \
> +        genaclperms.pl Makefile.am
> +	$(PERL) genaclperms.pl $< > $@

This is breaking 'make distcheck' with:

make[3]: Entering directory `/home/eblake/libvirt/libvirt-1.1.1/_build/docs'
perl ../../docs/genaclperms.pl ../../src/access/viraccessperm.h >
../../docs/aclperms.htmlinc
/bin/sh: ../../docs/aclperms.htmlinc: Permission denied

That is, when unpacking a tarball into read-only media (such as
exploding it onto a CDROM, then doing a VPATH build in a read-write tree
while pointing to the read-only source location), we are trying to
modify the source tree.  I'm working on a fix, hopefully before 1.1.2 is
out.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]