[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: shipped files must not depend on BUILT_SOURCES

On 08/30/2013 07:55 PM, Eric Blake wrote:
> 'make distcheck' was failing with:
> make[3]: Entering directory `/home/eblake/libvirt-tmp2/libvirt-1.1.1/_build/docs'
> perl ../../docs/genaclperms.pl ../../src/access/viraccessperm.h > ../../docs/aclperms.htmlinc
> /bin/sh: ../../docs/aclperms.htmlinc: Permission denied

> * docs/Makefile.am (BUILT_SOURCES): Delete.
> (CLEANFILES): Downgrade aclperms.htmlinc cleanup...
> (maintainer-clean-local): ...and move hvsupport.html.in...
> (MAINTAINERCLEANFILES): ...to a maintainer action.
> (hvsupport.html.in): Write into srcdir.
> (hvsupport.html): Ensure files are built in order.
> (aclperms.htmlinc): Honor silent make.
> (EXTRA_DIST): Ship aclperms.htmlinc.

> Pushing under the build-breaker rule.

>  dot_html_in = $(notdir $(wildcard $(srcdir)/*.html.in)) \
>    todo.html.in \
> -  hvsupport.html.in
> +  $(srcdir)/hvsupport.html.in
>  dot_html = $(dot_html_in:%.html.in=%.html)

Thankfully I tested before pushing - this hunk is spurious (it breaks
VPATH builds).  I had cleaned it out of the commit message with 'git
commit --amend' but had forgot to use '-a' to actually pick up the
change at the time I sent the mail.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]