[libvirt] [v3 08/32] virObject-ified virDomainEvent

Daniel P. Berrange berrange at redhat.com
Tue Dec 10 12:23:42 UTC 2013


On Mon, Dec 02, 2013 at 05:39:26PM +0100, Cédric Bosdonnat wrote:
> Added a parent class virObjectEvent for future event types
> ---
>  cfg.mk                   |   2 -
>  src/conf/domain_event.c  | 619 +++++++++++++++++++++++++++++++----------------
>  src/conf/domain_event.h  |   5 +-
>  src/libvirt_private.syms |   1 -
>  src/qemu/qemu_driver.c   |   2 +-
>  src/test/test_driver.c   |   4 +-
>  6 files changed, 413 insertions(+), 220 deletions(-)

> +static int virObjectEventOnceInit(void)
> +{
> +    if (!(virObjectEventClass = virClassNew(virClassForObject(),
> +                                             "virObjectEvent",
> +                                             sizeof(virObjectEvent),
> +                                             virObjectEventDispose)))
> +        return -1;
> +    if (!(virDomainEventClass = virClassNew(virObjectEventClass,
> +                                             "virDomainEvent",
> +                                             sizeof(virDomainEvent),
> +                                             virDomainEventDispose)))
> +        return -1;

I'm going to tweak the indentation when pushing this & following patches
to look like this instead:

     if (!(virDomainEventClass =
           virClassNew(virObjectEventClass,
                       "virDomainEvent",
                       sizeof(virDomainEvent),
                       virDomainEventDispose)))
         return -1;

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list