[libvirt] [PATCH 6/6] spec: clean up libvirtd and virtlockd service mgmt

Michal Privoznik mprivozn at redhat.com
Tue Dec 10 13:23:05 UTC 2013


On 09.12.2013 07:23, Michael Chapman wrote:
> - systemctl and the %systemd_* RPM macros can take multiple unit names
>   in the one invocation. Make use of this to avoid repeated systemd
>   daemon reloads.
> 
> - virtlockd was only properly enabled and disabled when using systemd,
>   but when systemd RPM macros were not available (e.g. on Fedora < 18).
>   Make sure it's enabled when systemd RPM macros are present, or when
>   using initscripts.
> 
> - Always use "reload" on virtlockd, not "condrestart". This allows it to
>   cleanly re-execute itself without losing running state. Ignore any
>   error should the reload fail.
> 
> - Move the reloading of virtlockd and libvirtd via their initscripts
>   into the daemon package's %postun scriptlet. These services must be
>   restarted after all of the libvirt-daemon-driver-* packages have
>   been upgraded during the same RPM transaction.
> 
> - Add a %triggerpostun executed only when upgrading an older
>   libvirt-daemon. As an older package would only reload libvirtd during
>   %post, and the newer package would only reload libvirtd during
>   %postun, such an upgrade would not reload libvirtd at all without the
>   trigger.
> 
> Signed-off-by: Michael Chapman <mike at very.puzzling.org>
> ---
>  libvirt.spec.in | 43 +++++++++++++++++++++++--------------------
>  1 file changed, 23 insertions(+), 20 deletions(-)

ACKed & pushed.

Michal




More information about the libvir-list mailing list