[libvirt] [PATCH 4/9] domain: introduce xml elements for throttle blkio cgroup

Gao feng gaofeng at cn.fujitsu.com
Wed Dec 11 07:18:09 UTC 2013


On 12/10/2013 11:30 PM, Daniel P. Berrange wrote:
> On Mon, Dec 02, 2013 at 02:47:59PM +0800, Gao feng wrote:
>> This patch introduces new xml elements under <blkiotune>,
>> we use these new elements to setup the throttle blkio
>> cgroup for domain. The new blkiotune node looks like this:
>>
>> <blkiotune>
>>   <device>
>>     <path>/path/to/block</path>
>>     <weight>1000</weight>
>>     <read_iops>10000</read_iops>
>>     <write_iops>10000</write_iops>
>>     <read_bps>10000</read_bps>
>>     <write_bps>10000</write_bps>
>>   </device>
>> </blkiotune>
> 
> Under the <disk> element we have
> 
>       <iotune>
>         <total_bytes_sec>10000000</total_bytes_sec>
>         <read_iops_sec>400000</read_iops_sec>
>         <write_iops_sec>100000</write_iops_sec>
>       </iotune>
> 
> Please use a consistent naming convention for these new
> elements - ie  read_iops_sec not read_iops.
> 

iops means i/o per second. iops_sec looks very strange.
since this alreay in and it is an user interface.

I will change my patchset.

Thanks




More information about the libvir-list mailing list