[libvirt] [PATCH] fix libvirt alignment on arm platforms

[Eric Blake]

On 12/12/2013 11:55 AM, Michal Privoznik wrote:
>>      int detail;
>> -};
>> +} ATTRIBUTE_PACKED;
> 
> (What an ancient e-mail :-) )

1970 was how many years before libvirt was even started?

> 
> I've raised the problem here:
> 
> https://www.redhat.com/archives/libvir-list/2013-December/msg00635.html
> 
> And Eric replied suggesting a fix:
> 
> https://www.redhat.com/archives/libvir-list/2013-December/msg00662.html
> 
> But I must say I like your approach more. Eric?

I still think ATTRIBUTE_PACKED in a parent class is wrong; it forces the
children to be packed, and may make it impossible to implement atomic
operations on a child member that was supposed to be aligned.  I'd much
rather fix the alignment in the parent class using portable constructs
than a compiler-specific non-alignment directive.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131212/55191e1e/attachment-0001.sig>