[libvirt] [PATCH] lxc: simplify command when connecting lxc multi console

[Chen Hanxiao]

> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange at redhat.com]
> Sent: Wednesday, December 18, 2013 5:55 PM
> To: Chen Hanxiao
> Cc: libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH] lxc: simplify command when connecting lxc multi
> console
> 
> On Wed, Dec 18, 2013 at 09:52:05AM +0000, Daniel P. Berrange wrote:
> > On Wed, Dec 18, 2013 at 04:54:27PM +0800, Chen Hanxiao wrote:
> > > From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> > >
> > > If we config more than one consoles for container,
> > > we always named them as "consoleN".
> > > We had to type a complex option "--devname consoleN".
> > > This patch enables option "--devname N"
> > > to be equal to  "--devname consoleN".
> > >
> > > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> > > ---
> > >  src/lxc/lxc_driver.c | 12 +++++++++++-
> > >  1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > NACK, I don't see any compelling reason todo this.
> 
> I should say though if we want simplification in virsh code that
> would be acceptablee
> 
>    virsh console -n 2 myguestname
> 
> would say connect to the 2nd <console> in the XML. virsh would
> get the XML description and find the 2nd <console> and extract
> the <alias> string from it, and then call the libvirt API with
> that string.
> 
Thanks, I see.

> Daniel
> --
> |: http://berrange.com      -o-
> http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-
> http://virt-manager.org :|
> |: http://autobuild.org       -o-
> http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-
> http://live.gnome.org/gtk-vnc :|