[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 02/13] Rename all domain list APIs to have virDomainObjList prefix



On Fri, Feb 01, 2013 at 11:18:24 +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The APIs names for accessing the domain list object are
> very inconsistent. Rename them all to have a standard
> virDomainObjList prefix.
> ---
>  src/conf/domain_conf.c            | 156 +++++++++++++++++---------------
>  src/conf/domain_conf.h            |  56 ++++++------
>  src/libvirt_private.syms          |  20 ++---
>  src/libxl/libxl_conf.h            |   2 +-
>  src/libxl/libxl_driver.c          | 172 ++++++++++++++++++-----------------
>  src/lxc/lxc_conf.h                |   2 +-
>  src/lxc/lxc_driver.c              | 144 ++++++++++++++---------------
>  src/lxc/lxc_process.c             |  12 +--
>  src/openvz/openvz_conf.c          |   6 +-
>  src/openvz/openvz_conf.h          |   2 +-
>  src/openvz/openvz_driver.c        |  67 +++++++-------
>  src/parallels/parallels_driver.c  |  52 +++++------
>  src/parallels/parallels_storage.c |   2 +-
>  src/parallels/parallels_utils.h   |   2 +-
>  src/qemu/qemu_conf.c              |   2 +-
>  src/qemu/qemu_conf.h              |   2 +-
>  src/qemu/qemu_domain.c            |   2 +-
>  src/qemu/qemu_driver.c            | 184 +++++++++++++++++++-------------------
>  src/qemu/qemu_migration.c         |   8 +-
>  src/qemu/qemu_process.c           |   2 +-
>  src/test/test_driver.c            | 179 ++++++++++++++++++------------------
>  src/uml/uml_conf.h                |   2 +-
>  src/uml/uml_driver.c              | 140 ++++++++++++++---------------
>  src/vmware/vmware_conf.c          |   7 +-
>  src/vmware/vmware_conf.h          |   2 +-
>  src/vmware/vmware_driver.c        |  72 +++++++--------
>  26 files changed, 665 insertions(+), 632 deletions(-)

Pretty big but quite mechanical. You could have changed

    type function(...)

into

    type
    function(...)

in all places rather than in just a few places but don't bother doing
that now. Nice thing is that all the renames and reordering of function
parameters can be checked by the compiler. And it doesn't complain about
anything, even make check and syntax-check passes.

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]