[libvirt] [PATCH 06/17] virsh-volume: Update volume commands to use vshCommandOptStringReq

Peter Krempa pkrempa at redhat.com
Mon Feb 4 11:13:27 UTC 2013


On 01/31/13 06:25, Osier Yang wrote:
> On 2013年01月22日 02:07, Peter Krempa wrote:
>> ---
>>   tools/virsh-volume.c | 69
>> +++++++++++++++++++++-------------------------------
>>   1 file changed, 28 insertions(+), 41 deletions(-)
>>
>> diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c

>>           return false;
>>
>> -    if (vshCommandOptString(cmd, "capacity",&capacityStr)<= 0)
>> +    if (vshCommandOptStringReq(ctl, cmd, "capacity",&capacityStr)<= 0)

The comparison operator needs to be changed to "<" here, as you pointed 
out in other patches.

>>           goto cleanup;
>>       virSkipSpaces(&capacityStr);
>>       if (*capacityStr == '-') {
>
> ACK

Thanks.

Peter




More information about the libvir-list mailing list