[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: Add libcurl dependency to libvirt_driver.la



On Fri, Feb 01, 2013 at 01:45:19PM +0100, Jiri Denemark wrote:
> libvirt.c calls curl_global_init() if WITH_CURL is defined and thus it
> should be linked with libcurl. This fixes link failure in case neither
> xenapi nor esx driver is enabled (they are the only users of libcurl).
> ---
>  src/Makefile.am | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 070a089..f6162df 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -792,9 +792,11 @@ noinst_LTLIBRARIES += libvirt_driver.la
>  libvirt_la_BUILT_LIBADD += libvirt_driver.la
>  libvirt_driver_la_SOURCES = $(DRIVER_SOURCES)
>  
> -libvirt_driver_la_CFLAGS = $(NUMACTL_CFLAGS) $(GNUTLS_CFLAGS) \
> +libvirt_driver_la_CFLAGS = \
> +		$(NUMACTL_CFLAGS) $(GNUTLS_CFLAGS) $(CURL_CFLAGS) \
>  		-I$(top_srcdir)/src/conf $(AM_CFLAGS)
> -libvirt_driver_la_LIBADD = $(NUMACTL_LIBS) $(GNUTLS_LIBS) $(DLOPEN_LIBS)
> +libvirt_driver_la_LIBADD = \
> +		$(NUMACTL_LIBS) $(GNUTLS_LIBS) $(CURL_LIBS) $(DLOPEN_LIBS)
>  
>  USED_SYM_FILES = $(srcdir)/libvirt_private.syms

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]