[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] complete virterror->virerror name change



Quoting Eric Blake (eblake redhat com):
> On 02/01/2013 12:55 PM, Serge Hallyn wrote:
> > Quoting Eric Blake (eblake redhat com):
> >> On 01/30/2013 08:05 PM, Serge Hallyn wrote:
> >>> Without these two string changes in generator.py, the
> >>> virGetLastError wrapper does not get created in
> >>> /usr/share/pyshared/libvirt.py.  Noticed when running
> >>> tests with virt-install.
> >>>
> >>> Signed-off-by: Serge Hallyn <serge hallyn ubuntu com>
> >>> ---
> >>>  python/generator.py | 4 ++--
> >>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> ACK.
> >>
> >> Bummer - that means the python bindings are broken in the 1.0.2 release.
> > 
> > D'oh, with my patch, Chuck was also getting the following error:
> > 
> > chuck homer:~/work/server/libvirt/libvirt-1.0.2/python/tests$ python error.py 
> > Traceback (most recent call last):
> >  File "error.py", line 35, in <module>
> >   elif errno[0] == libvirt.VIR_ERR_NO_CONNECT or \
> > AttributeError: 'module' object has no attribute 'VIR_ERR_NO_CONNECT'
> > 
> > presumably because include/libvirt/virterror.h still exists, and my
> > patch was over-zealous.
> 
> Does that mean we need a followup patch that looks for both virerror AND
> virterror?

I'm afraid so.  I don't know if keeping virterror.h with that name was
intentional or not, and can't claim to understand generator.py enough
to know if there is a better fix.

(To test, build and install the new libvirt, and cd
libvirt-1.0.2/python/tests and run ./error.py)

-serge


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]