[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/2] Support shifted magic in storage files



On 02/04/2013 02:49 PM, Martin Kletzander wrote:
> Some files have the magic shifted to some offset other than 0, so we
> have to support that.  I also cleaned up some lines to be more
> readable and added missing magic for iso file format.
> ---
>  src/util/virstoragefile.c | 55 ++++++++++++++++++++++++++---------------------
>  1 file changed, 31 insertions(+), 24 deletions(-)

>      [VIR_STORAGE_FILE_ISO] = {
> -        NULL, /* XXX there's probably some magic for iso we can validate too... */
> -        ".iso",
> +        32769, "CD001", ".iso",

Oh, I didn't notice that this wouldn't work until I saw patch 2; you
need to hoist a hunk of that patch into this one.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]