[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirtd: Don't check WITH_LIBVIRTD in C source files



On Mon, Feb 04, 2013 at 10:08:42PM -0600, Doug Goldstein wrote:
> On Mon, Feb 4, 2013 at 8:20 PM, Hu Tao <hutao cn fujitsu com> wrote:
> > Don't check WITH_LIBVIRTD in C source files because we will build
> > the sources even without libvirtd.
> > ---
> >  src/driver.h               | 4 ----
> >  src/libvirt.c              | 7 -------
> >  src/libvirt_internal.h     | 2 --
> >  src/remote/remote_driver.c | 6 ------
> >  src/xen/xen_driver.c       | 6 +-----
> >  5 files changed, 1 insertion(+), 24 deletions(-)
> >
> > @@ -216,7 +215,6 @@ static virStateDriver state_driver = {
> >      .initialize = xenInitialize,
> >  };
> >
> > -#endif
> >
> >  /*----- Dispatch functions. -----*/
> >
> > @@ -2398,9 +2396,7 @@ static virDriver xenUnifiedDriver = {
> >  int
> >  xenRegister(void)
> >  {
> > -#ifdef WITH_LIBVIRTD
> >      if (virRegisterStateDriver(&state_driver) == -1) return -1;
> > -#endif
> >
> >      return virRegisterDriver(&xenUnifiedDriver);
> >  }
> > --
> > 1.8.0.1.240.ge8a1f5a
> 
> What platform or target were you aiming this for that this was needed?
> This appears to prevent supporting backends from being registered
> while the other parts of the code provide other functionality.

I'm not sure I understand what your concern is here. If we build with
--without-libvirtd, then the 'xen' driver is forcably disabled. So
this change should effectively be a no-op in this area.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]