[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 08/13] Rename all PCI device functions to have a standard name prefix



On Mon, Feb 04, 2013 at 06:31:10PM +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:30 +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Rename all the pciDeviceXXX and pciXXXDevice APIs to have a
> > fixed virPCIDevice name prefix
> 
> Some functions gained just virPCI prefix, I guess that means they don't
> take virPCIDevicePtr arguments. In any case, the shorter prefix the
> better so I'm not opposed to it :-)
> 
> ...
> > diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
> > index 1b8a9cd..b5d7c5e 100644
> > --- a/src/qemu/qemu_hostdev.c
> > +++ b/src/qemu/qemu_hostdev.c
> ...
> > @@ -856,7 +856,7 @@ void qemuDomainReAttachHostdevDevices(virQEMUDriverPtr driver,
> >                                                     hostdevs,
> >                                                     nhostdevs))) {
> >          virErrorPtr err = virGetLastError();
> > -        VIR_ERROR(_("Failed to allocate pciDeviceList: %s"),
> > +        VIR_ERROR(_("Failed to allocate virPCIDeviceList: %s"),
> 
> Why not just "PCI device list"?
> 
> >                    err ? err->message : _("unknown error"));
> >          virResetError(err);
> >          goto cleanup;
> ...
> > diff --git a/src/util/virpci.c b/src/util/virpci.c
> > index 0fb9923..695f372 100644
> > --- a/src/util/virpci.c
> > +++ b/src/util/virpci.c
> ...
> > @@ -748,39 +748,39 @@ pciTryPowerManagementReset(pciDevice *dev, int cfgfd)
> >  }
> >  
> >  static int
> > -pciInitDevice(pciDevice *dev, int cfgfd)
> > +virPCIDeviceInitDevice(virPCIDevicePtr dev, int cfgfd)
> 
> Why not just virPCIDeviceInit?

Yes, it was my intention to remove the double 'Device' from
all functions. I guess I missed a few.

> ACK whether you implement changes I suggested or not (or just some of
> them) as long as make all check syntax-check succeeds.

Will fix them all

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]