[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: reserve more fds for commandtest



On 05.02.2013 17:17, Eric Blake wrote:
> Commit 39c77fe triggered random failures, depending on the platform
> and what other fds leak into the testsuite (for me, it passed on
> RHEL 6 but failed on Fedora 18).  The reason was that we were
> expecting an fd that fell outside of our reserved range.  By reserving
> a larger range, the test once again passes on all platforms.
> 
> * tests/commandtest.c (mymain): Reserve enough fds.
> ---
> 
> I'll wait a bit for a review, but if I don't get one, I'll push
> this under the build-breaker rule.
> 
>  tests/commanddata/test3.log |  2 +-
>  tests/commandtest.c         | 13 +++++++++++--
>  2 files changed, 12 insertions(+), 3 deletions(-)

ACK. Sorry for breaking the test suite.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]