[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/6] storage: add support for creating qcow3 images



On 02/05/13 18:14, Daniel P. Berrange wrote:
> 
> I can understand why you're doing this, but gives me a really bad
> feeling. After 5 years we've finally stopped parsing -help from
> the QEMU binary...only to start doing the same for qemu-img.
> 
>> ...
> 
> IMHO we should just invoke qemu-img with the feature list we have, and
> rely on it to report any unsupported features itself, rather than trying
> to pre-detect them ourselves.
> 
> Daniel

I only did it because of the 'compat' feature, which might be needed to
create qcow2 images in the future, if the default of qemu-img gets
changed to qcow3.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]