[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Turn virCapabilities into a virObject



On Wed, Feb 06, 2013 at 02:36:38PM +0100, Jiri Denemark wrote:
> On Wed, Feb 06, 2013 at 11:54:49 +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > To enable virCapabilities instances to be reference counted,
> > turn it into a virObject. All cases of virCapabilitiesFree
> > turn into virObjectUnref
> ...

> > diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h
> > index 60c4109..8fada4e 100644
> > --- a/src/qemu/qemu_conf.h
> > +++ b/src/qemu/qemu_conf.h
> > @@ -164,7 +164,7 @@ struct _virQEMUDriver {
> >      /* Atomic increment only */
> >      int nextvmid;
> >  
> > -    /* Immutable pointer. Unsafe APIs XXX */
> > +    /* Immutable pointer. Immutable object */
> >      virCgroupPtr cgroup;
> >  
> >      /* Atomic inc/dec only */
> 
> Are you sure you're changing the right comment? I'd expect the comment
> for virCapsPtr caps would be changed.

Actually this should have been in a previous change, already
submitted. After my original analysis I found out the cgroups
APIs were indeed safe.

The change for 'virCapsPtr caps' is done in the 3rd patch
in this series.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]