[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 11/13] docs: syntax highlight code blocks using SHJS



On 01/30/2013 08:38 AM, Claudio Bley wrote:
> Add minimized CSS and Javascript files of SHJS
> (http://shjs.sourceforge.net/) required for highlighting C code.
> 
> Call sh_highlightDocument() in onload event handler.
> 
> Since the new files are generated by a minifier tool, exclude
> them from being checked by syntax-check for proper newlines at EOF.
> 
> Signed-off-by: Claudio Bley <cbley av-test de>
> ---
>  cfg.mk                |    2 +-
>  docs/newapi.xsl       |    2 +-
>  docs/page.xsl         |    5 ++++-
>  docs/sh_c.min.js      |    1 +
>  docs/sh_emacs.min.css |    1 +
>  docs/sh_main.min.js   |    4 ++++
>  6 files changed, 12 insertions(+), 3 deletions(-)
>  create mode 100644 docs/sh_c.min.js
>  create mode 100644 docs/sh_emacs.min.css
>  create mode 100644 docs/sh_main.min.js

I'm still not convinced whether to take these patches, but if we do, you
are missing Makefile.am changes that ensure the new files are shipped in
the tarball and installed as part of 'make install'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]