[libvirt] [Patch]Fix bugs of Sheepdog storage driver

Daniel P. Berrange berrange at redhat.com
Wed Feb 6 17:26:14 UTC 2013


On Thu, Feb 07, 2013 at 01:09:52AM +0800, harryxiyou at gmail.com wrote:
> 
> Signed-off-by: Harry Wei <harryxiyou at gmail.com>
> 
> ---
>  src/storage/storage_backend_sheepdog.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c
> index cd18f33..2cbfe01 100644
> --- a/src/storage/storage_backend_sheepdog.c
> +++ b/src/storage/storage_backend_sheepdog.c
> @@ -168,9 +168,12 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
>      virCommandAddArgFormat(cmd, "%llu", vol->capacity);
>      virStorageBackendSheepdogAddHostArg(cmd, pool);
>      ret = virCommandRun(cmd, NULL);
> +	if (ret < 0)
> +        goto cleanup;

Still has the same flaw using 'tab' as the previous patch you sent.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list