[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4 v4] New API virNodeDeviceLookupSCSIHostByWWN



On 02/04/2013 08:03 AM, Osier Yang wrote:
> v3 - v4:
>   * Only rebasing
> 
> v2 - v3:
>   * Validate the specified wwnn,wwpn pair before applying it
>     to the new API in virsh-nodedev.c
> 
> v1 - v2:
>   * Per Daniel's suggestion, change the API name from
>     virNodeDeviceLookupByWWN into
>     virNodeDeviceLookupSCSIHostByWWN.
> 
> Osier Yang (4):
>   Introduce API virNodeDeviceLookupSCSIHostByWWN
>   remote: Wire up the remote protocol
>   nodedev: Implement virNodeDeviceLookupSCSIHostByWWN
>   virsh: Use virNodeDeviceLookupSCSIHostByWWN
> 
>  include/libvirt/libvirt.h.in         |    5 ++
>  src/driver.h                         |    6 ++
>  src/libvirt.c                        |   46 ++++++++++++++++
>  src/libvirt_public.syms              |    5 ++
>  src/node_device/node_device_driver.c |   13 +++--
>  src/node_device/node_device_driver.h |    4 ++
>  src/node_device/node_device_hal.c    |    1 +
>  src/node_device/node_device_udev.c   |    1 +
>  src/remote/remote_driver.c           |    1 +
>  src/remote/remote_protocol.x         |   13 ++++-
>  src/remote_protocol-structs          |    9 +++
>  src/rpc/gendispatch.pl               |    5 ++-
>  tools/virsh-nodedev.c                |   98 ++++++++++++++++++++++++++--------
>  tools/virsh.pod                      |   15 +++--
>  14 files changed, 187 insertions(+), 35 deletions(-)
> 


I didn't see anything jump out at me with these changes.  I don't
remember looking at v1->v3 and I'm still learning the ins and outs of
the code.

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]