[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 0/6] Introduce virCommandDoAsyncIO

On 06.02.2013 12:51, Daniel P. Berrange wrote:
> On Mon, Feb 04, 2013 at 03:56:37PM +0100, Michal Privoznik wrote:
>> Currently, if we want to use IO with asynchronous command we have
>> to copy code from virFileWrapperFd to misuse our event loop for
>> reading and writing to the command. However, we can extend our
>> virCommand implementation to automatically set things up.
> There is something racy in this series of changes. About 50% of
> the time when running a domain save, I see warnings about closing
> invalid file descriptors & invalid watches from libvirtd
> 2013-02-06 11:41:43.766+0000: 19078: warning : virEventPollRemoveHandle:183 : Ignoring invalid remove watch -1
> 2013-02-06 11:41:43.766+0000: 19078: warning : virFileClose:65 : Tried to close invalid fd 25

Yeah, I've notice some errors as well, however with lower ratio.
I believe this is the fix:



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]